Skip to content

Add importer for Neon#9

Open
bobobo1618 wants to merge 4 commits intoBananaAccounting:masterfrom
bobobo1618:patch-1
Open

Add importer for Neon#9
bobobo1618 wants to merge 4 commits intoBananaAccounting:masterfrom
bobobo1618:patch-1

Conversation

@bobobo1618
Copy link

I wrote this up for CSV files from https://www.neon-free.ch/

Unfortunately the handling of foreign currencies is broken and I'm not sure how they're intended to work. I thought it was intuitive to set Income/Expenses for CHF and AmountCurrency, ExchangeCurrency and ExchangeRate for foreign currencies but Banana does something totally unexpected when given these inputs: it ignores the amount set in Income/Expenses and replaces it with AmountCurrency.

I guess I should go lower level and use AccountCredit and AccountDebit to configure the direction of the transfer but it isn't clear how to get the actual account names.

So I don't expect this to work straight away but please let me know how you'd prefer this to be handled.

@dzucchetti
Copy link
Contributor

Thank.
Try with:

  • When negative invert also the Amount Currency
  • Remove the "banana['ExchangeRate'] = csvObj['Exchange rate'];". The exchange rate is calculated by banana.
  • Kindly provide also a example csv file, with not personal data, so we can add a test case.

@dzucchetti dzucchetti closed this Aug 31, 2023
@bobobo1618
Copy link
Author

Thank you, it seems I actually just forgot to reload the extension. Everything works now.

  • The Amount Currency is already negative from the CSV
  • Isn't it better to keep Neon's exchange rate? That way Banana could calculate the exchange rate and flag any differences between what it calculates and what Neon claimed?
  • There are a few lines of CSV for testing in the file itself.

@bobobo1618
Copy link
Author

Actually sorry, I was wrong, the problem was still there.

When I remove ExchangeRate and set Income, Expenses, Amount and ExchangeCurrency, the amount isn't imported and no currency exchange rate is shown.

@bobobo1618
Copy link
Author

Okay, got it working. It was a stupid mistake: I changed the object but I didn't update the CSV headers.

@dzucchetti
Copy link
Contributor

Best!

Do you want to resubmit the new version. Kindly create a subdirectory "neon-free" under ImportApps and put the script file.

@dzucchetti dzucchetti reopened this Sep 4, 2023
@bobobo1618
Copy link
Author

Done, I tried to keep everything consistent with the other importers.

@patrickpasquillo
Copy link
Contributor

Hi @bobobo1618 , I am in charge of publishing your extension within the Banana Accounting Plus Community.

You can find detailed information about it on this page: Sharing extensions with the Community. I kindly ask you to contact us by e-mail, as described on the page, to better define the publication.

Thank you for your contribution, and I hope to hear from you soon.

@patrickpasquillo
Copy link
Contributor

Hi @bobobo1618 , we published the modified extension. Now you can find it between available extensions on Banana Accounting Plus and at this web page.. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants