Fix resource leak in VoiceConverter #1
Conversation
The `convert_voice` method in `VoiceConverter` did not reliably delete temporary `.json` metadata files created by the `urvc_convert` function. The cleanup logic was incorrectly placed inside a conditional block that only executed when the output filename differed from the source filename. This caused orphaned `.json` files to accumulate in the temporary directory during long-running sessions, leading to a resource leak. This commit moves the cleanup logic out of the conditional block, ensuring that the `.json` file is always deleted after every conversion, regardless of the output filename. A new unit test has been added to verify this fix.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Removes the temporary test file `tests/test_bug.py` that was created to debug and verify a resource leak fix. This file is no longer needed.
This change fixes a resource leak in the
VoiceConverterclass. Theconvert_voicemethod was not reliably deleting temporary.jsonmetadata files, causing them to accumulate over time. The fix ensures that these files are always cleaned up after each conversion. A new test has been added to verify the fix.PR created automatically by Jules for task 13959253303143988925 started by @Camier