Skip to content

Conversation

@Camier
Copy link
Member

@Camier Camier commented Nov 14, 2025

Summary

  • ensure rwc --version always resolves the package version without requiring an installed distribution
  • keep the VoiceConverter.use_rmvpe flag aligned with the user request while tracking RMVPE availability for runtime fallbacks
  • warn and gracefully fall back to CREPE pitch extraction when RMVPE assets are missing

Testing

  • pytest

Codex Task

Copilot AI review requested due to automatic review settings November 14, 2025 03:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes two issues: ensuring the CLI's --version command always displays the package version correctly, and improving RMVPE (pitch extraction model) fallback behavior to maintain the user's preference while gracefully handling missing model files.

  • Adds explicit version and program name to CLI's @click.version_option decorator
  • Introduces rmvpe_available flag to track RMVPE model availability separately from user preference
  • Adds warning when RMVPE is requested but unavailable, with automatic fallback to CREPE

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
rwc/cli/init.py Imports __version__ and passes it explicitly to @click.version_option to ensure version display works without requiring installed distribution
rwc/core/init.py Separates RMVPE user preference (use_rmvpe) from availability (rmvpe_available), adds warning for missing RMVPE model, and updates pitch extraction method selection logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants