Closes #5033: intermittent arkouda_makefile test failures#5454
Open
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Open
Closes #5033: intermittent arkouda_makefile test failures#5454ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-enables the
install-pytablesstep in GitHub Actions CI and updates the PyTables dependency Makefile to install from a fixed upstream tag (rather than an arbitrary repo head).Motivation
pytables.mklogic cloned the PyTables repo but did not pin a version, and also mixed Make directives inside a shell recipe, which is brittle.Changes
Make install-pytablesstep, with retries, and passingHDF5_DIRto ensure the local HDF5 install is used.make/deps/pytables.mk):PYTABLES_VERSION,PYTABLES_TAG, andPYTABLES_DIR.ifeq-inside-recipe block with a POSIX shellifcheck.v$(PYTABLES_VERSION)before updating submodules.pip install ./PyTablesfrom the checked-out working tree.Version pinned
v3.11.1(viaPYTABLES_VERSION ?= 3.11.1).Testing
make install-hdf5 install-pytables DEP_BUILD_DIR=...(ensureHDF5_DIRis set as in CI).Notes
If a newer PyTables release is desired later, bump
PYTABLES_VERSIONinmake/deps/pytables.mk.Closes #5033: intermittent arkouda_makefile test failures