Skip to content

Closes #5033: intermittent arkouda_makefile test failures#5454

Open
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
ajpotts:5033_intermittent_arkouda_makefile_test_failures
Open

Closes #5033: intermittent arkouda_makefile test failures#5454
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
ajpotts:5033_intermittent_arkouda_makefile_test_failures

Conversation

@ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Mar 4, 2026

Summary

This PR re-enables the install-pytables step in GitHub Actions CI and updates the PyTables dependency Makefile to install from a fixed upstream tag (rather than an arbitrary repo head).

Motivation

  • CI previously skipped PyTables installation (step was commented out), which reduced coverage for any code paths depending on PyTables/HDF5.
  • The existing pytables.mk logic cloned the PyTables repo but did not pin a version, and also mixed Make directives inside a shell recipe, which is brittle.
  • Pinning to a tag makes builds reproducible while still using the same “clone + local install” mechanism.

Changes

  • CI: Un-commented and restored the Make install-pytables step, with retries, and passing HDF5_DIR to ensure the local HDF5 install is used.
  • Makefile (make/deps/pytables.mk):
    • Added PYTABLES_VERSION, PYTABLES_TAG, and PYTABLES_DIR.
    • Replaced the non-functional ifeq-inside-recipe block with a POSIX shell if check.
    • Fetches tags and checks out v$(PYTABLES_VERSION) before updating submodules.
    • Installs via pip install ./PyTables from the checked-out working tree.

Version pinned

  • PyTables v3.11.1 (via PYTABLES_VERSION ?= 3.11.1).

Testing

  • CI should now exercise the PyTables install step again.
  • Locally: run make install-hdf5 install-pytables DEP_BUILD_DIR=... (ensure HDF5_DIR is set as in CI).

Notes

If a newer PyTables release is desired later, bump PYTABLES_VERSION in make/deps/pytables.mk.

Closes #5033: intermittent arkouda_makefile test failures

@ajpotts ajpotts requested a review from jaketrookman March 4, 2026 22:43
@ajpotts ajpotts marked this pull request as ready for review March 4, 2026 22:43
@ajpotts ajpotts requested a review from jabraham17 March 5, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intermittent arkouda_makefile test failures

1 participant