Skip to content

Conversation

@N6REJ
Copy link
Collaborator

@N6REJ N6REJ commented Feb 9, 2025

PR Type

enhancement, configuration changes


Description

  • Added configuration file for Git version 2.47.1.

  • Added configuration file for Git version 2.48.0-rc2.

  • Updated bundle.release version in build.properties.


Changes walkthrough 📝

Relevant files
Configuration changes
bearsampp.conf
Add configuration for Git version 2.47.1                                 

bin/git2.47.1/bearsampp.conf

  • Added configuration file for Git version 2.47.1.
  • Defined gitVersion, gitExe, gitBash, and gitScanStartup.
  • Included placeholder for bundleRelease.
  • +6/-0     
    bearsampp.conf
    Add configuration for Git version 2.48.0-rc2                         

    bin/git2.48.0-rc2/bearsampp.conf

  • Added configuration file for Git version 2.48.0-rc2.
  • Defined gitVersion, gitExe, gitBash, and gitScanStartup.
  • Included placeholder for bundleRelease.
  • +6/-0     
    build.properties
    Update `bundle.release` version                                                   

    build.properties

    • Updated bundle.release version from 2024.11.1 to 2025.2.9.
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Path Validation

    Verify that the relative paths specified for gitExe and gitBash are correct and point to valid executables

    gitExe = "bin/git.exe"
    gitBash = "bin/sh.exe"

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Use absolute paths for executables

    Use absolute paths for executable files to prevent potential path resolution
    issues and ensure consistent behavior across different environments.

    bin/git2.47.1/bearsampp.conf [2-3]

    -gitExe = "bin/git.exe"
    -gitBash = "bin/sh.exe"
    +gitExe = "${BEARSAMPP_ROOT}/bin/git2.47.1/bin/git.exe"
    +gitBash = "${BEARSAMPP_ROOT}/bin/git2.47.1/bin/sh.exe"
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: Using absolute paths with environment variables is a significant improvement for reliability, as it prevents path resolution issues and ensures consistent behavior across different environments. This is particularly important for executable files.

    Medium

    @jwaisner jwaisner merged commit 374c59c into main Feb 9, 2025
    @jwaisner jwaisner deleted the 2.48.0 branch February 9, 2025 17:14
    @N6REJ N6REJ restored the 2.48.0 branch February 15, 2025 22:00
    @N6REJ N6REJ deleted the 2.48.0 branch July 5, 2025 22:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants