Skip to content

feat: implement timezone functionality#28

Open
Ethan225300 wants to merge 1 commit intodevfrom
feat/CP-31-User-Profile-update-timezone
Open

feat: implement timezone functionality#28
Ethan225300 wants to merge 1 commit intodevfrom
feat/CP-31-User-Profile-update-timezone

Conversation

@Ethan225300
Copy link
Contributor

@Ethan225300 Ethan225300 commented May 4, 2024

  • Created the Timezone model: Defined the structure for storing timezone data in the database.
  • Implemented TimezoneService: Developed methods to retrieve all available timezones and update user-specific timezone settings.
  • Added API endpoints for fetching all timezones and updating the user's timezone.
  • Handled GraphQL queries and mutations related to timezone data.
  • Added relative tests
  • Resolve CP-31
451f0d1947a592a8b9dd2738a574f2f 9cf795ee4f361d4aa86039cedbc2382 09508e9b739984d4c97c7b4f4d03100

Copy link
Contributor

@Chris-Wang Chris-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use controllers for our graphql services, please reimplemented the timezone features

Also, please attach updated gql queries and testing result on playground

@Ethan225300 Ethan225300 force-pushed the feat/CP-31-User-Profile-update-timezone branch 2 times, most recently from 1902035 to 732d641 Compare May 24, 2024 16:09
@Ethan225300 Ethan225300 requested a review from Chris-Wang June 11, 2024 05:40
Copy link
Contributor

@Chris-Wang Chris-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to resolve comments

@Ethan225300 Ethan225300 force-pushed the feat/CP-31-User-Profile-update-timezone branch 2 times, most recently from 40f11d9 to e4fd014 Compare June 18, 2024 15:52
@Ethan225300 Ethan225300 requested a review from Chris-Wang June 18, 2024 15:55
Copy link
Contributor

@Chris-Wang Chris-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Consider using GqlAuthGuard, we don't need timezone service to validateUserToken

hint: check how we did on updating user profile

@Ethan225300 Ethan225300 force-pushed the feat/CP-31-User-Profile-update-timezone branch from 90749bb to 924c076 Compare June 20, 2024 07:34
@Ethan225300 Ethan225300 requested a review from Chris-Wang June 20, 2024 07:38
- Created the Timezone model: Defined the structure for storing timezone data in the database.
- Implemented TimezoneService: Developed methods to retrieve all available timezones and update user-specific timezone settings.
- Added API endpoints for fetching all timezones and updating the user's timezone.
- Handled GraphQL queries and mutations related to timezone data.
- Added relative tests
Resolve CP-31
@Ethan225300 Ethan225300 force-pushed the feat/CP-31-User-Profile-update-timezone branch from 5392842 to a82f90e Compare June 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants