Open
Conversation
Chris-Wang
requested changes
Apr 28, 2024
...ainers/Account/AccountManagement/components/ChangePassword/components/ChangePasswordForm.tsx
Outdated
Show resolved
Hide resolved
...ainers/Account/AccountManagement/components/ChangePassword/components/ChangePasswordForm.tsx
Outdated
Show resolved
Hide resolved
...ainers/Account/AccountManagement/components/ChangePassword/components/ChangePasswordForm.tsx
Outdated
Show resolved
Hide resolved
...ainers/Account/AccountManagement/components/ChangePassword/components/ChangePasswordForm.tsx
Outdated
Show resolved
Hide resolved
...ainers/Account/AccountManagement/components/ChangePassword/components/ChangePasswordForm.tsx
Outdated
Show resolved
Hide resolved
src/containers/Account/AccountManagement/components/ChangePassword/index.ts
Outdated
Show resolved
Hide resolved
...ainers/Account/AccountManagement/components/ChangePassword/components/ChangePasswordForm.tsx
Outdated
Show resolved
Hide resolved
src/containers/Account/AccountManagement/components/ChangePassword/ChangePassword.test.tsx
Outdated
Show resolved
Hide resolved
oopshell
force-pushed
the
feat/CP-34-update-password-page
branch
3 times, most recently
from
1d59a08 to
767e6b0
Compare
Contributor
|
Need to merge api part firstly |
Chris-Wang
requested changes
Jun 10, 2024
Contributor
Chris-Wang
left a comment
Chris-Wang
left a comment
There was a problem hiding this comment.
Need to update sideBar and topBar to add update component,
commits have duplicated text,
please merge the latest dev to your branch
oopshell
force-pushed
the
feat/CP-34-update-password-page
branch
from
767e6b0 to
72b69aa
Compare
oopshell
force-pushed
the
feat/CP-34-update-password-page
branch
from
b6310bd to
2ee311d
Compare
Chris-Wang
requested changes
Jun 12, 2024
Contributor
Chris-Wang
left a comment
Chris-Wang
left a comment
There was a problem hiding this comment.
Still there're no access to the new component from ui
Author
Ya, I see the problem, and working on it. The backend data input schema changes, so I need to update several files in the frontend. I will fix this as soon as possible. Also, after fixing problems, I will add entry of the page to sidebar and topbar. |
oopshell
force-pushed
the
feat/CP-34-update-password-page
branch
3 times, most recently
from
f02ef6a to
05f1b8b
Compare
SeijaHuang
force-pushed
the
feat/CP-34-update-password-page
branch
2 times, most recently
from
17eb883 to
b025748
Compare
Contributor
|
Feat: add update password page Added update password link in the account management page
Resolve CP-34 |
SeijaHuang
force-pushed
the
feat/CP-34-update-password-page
branch
6 times, most recently
from
92ef5be to
0ed9c0c
Compare
Added update password link in the account management page - Added unit tests for update password link Added update password page - Implemented update password form - Added unit tests for update password page Modularized update password link - Added protected/account/management fold to contain all components related to update password link Modularized update password page - Added protected/account/update fold to contain all components related to update password page - Refactor update password form in alignment with login-form and setting-form modularized before - Refactor the test file to update codes with new refactored form - Fixed the conflicts between CP-34 with dev Refactor shared component - move FormIcon, FormInput, and FormPasswordInput into shared component fold to make it shareable between all the forms, including setting page form and update password form Resolve CP-34
SeijaHuang
force-pushed
the
feat/CP-34-update-password-page
branch
from
0ed9c0c to
6b44bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main feature
Added user password reset page:
Added testing:
Resolve CP-34