Open
Conversation
Chris-Wang
requested changes
Jun 11, 2024
Contributor
Chris-Wang
left a comment
Chris-Wang
left a comment
There was a problem hiding this comment.
needs:
- squash commits
- fix failed test
windforce852
force-pushed
the
feat/CP-32-switch-language-v2
branch
2 times, most recently
from
2d13228 to
942a07f
Compare
Author
|
done squash commits AppSetting page dropdown gloss fix applied here but further UI improvement will and should be done in CP36 (another choice is to combine both ticket into one PR) |
Add internationalization - Implemented internationalization using next-intl library - Implemented language switch between English and Chinese Add theme switch - Implemented theme switch between light and dark in accounting setting page Refactor account setting page - Modularized account setting page Resolve CP-22 NEED TO BE DONE - Unit test for all pages implemented internationalization NEED TO BE DONE - Unit test for all pages implemented internationalization
SeijaHuang
force-pushed
the
feat/CP-32-switch-language-v2
branch
from
c034c34 to
eea5dc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add i18n switch language
language can be switched from AppSetting page
i18n can affect sidebarContent and AppSetting page now
further implement to other page will be execute after code review