Open
Conversation
Chris-Wang
requested changes
Jun 14, 2024
Contributor
Chris-Wang
left a comment
Chris-Wang
left a comment
There was a problem hiding this comment.
Please try to solve the ui mismatch issue in safari:
Chris-Wang
requested changes
Jun 21, 2024
| /> | ||
| </FormGroupField> | ||
| </FormGroup> | ||
|
|
Contributor
There was a problem hiding this comment.
No need to leave between lines in tsx return part
Author
There was a problem hiding this comment.
do you mean /> in line 76 should merge to the tail of 75? done
| FormGroupLabel, | ||
| } from '@/shared/components/form/FormElements'; | ||
| import { Controller, useForm } from 'react-hook-form'; | ||
|
|
Contributor
There was a problem hiding this comment.
need to remove empty lines here
Author
|
ready to rebase after most updated dev issue solved |
windforce852
force-pushed
the
feat/CP-36-add-setting-page-v2
branch
from
be49d19 to
7b3756c
Compare
Added AppSetting page: - implemented 'language' drop down, with Eng and Chn language options - implemented 'theme' drop down, with two staic options 'light', 'dark' - drop down were wrote by custom ul li, implemented within react-hook-form - added AppSetting page into routeConfig - added entry from side nav bar - added unit tests that passed after migrate to next - changed theme hook to fit next js Resolve CP-36
windforce852
force-pushed
the
feat/CP-36-add-setting-page-v2
branch
from
7b3756c to
bb08ad5
Compare
Author
|
Pushed a new verion that included the custom dropdown that using 'ul' 'li' rather than 'select' 'option' ; and added related test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Feature: