fix: Refine the color of the show password icon button#55
Open
floraSimpleDev wants to merge 1 commit intodevfrom
Open
fix: Refine the color of the show password icon button#55floraSimpleDev wants to merge 1 commit intodevfrom
floraSimpleDev wants to merge 1 commit intodevfrom
Conversation
fixed the user login/register page: - add hover and click effects for the show password icon button (eye icon button) Resolve CP-84
Chris-Wang
requested changes
Aug 15, 2024
Contributor
Chris-Wang
left a comment
Chris-Wang
left a comment
There was a problem hiding this comment.
PR Description needs screenshot of your work;
Still need to work on:
- user higher contrast colour for different button status
- keep different colour when status changes, i.e. it should show different colour when showPassword is active/in-active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed the user login/register page:
Resolve CP-84