fix: pre-calculate cluster node positions and reduce drag disturbance#23
Open
Shanb007 wants to merge 2 commits intoBetterDB-inc:masterfrom
Open
fix: pre-calculate cluster node positions and reduce drag disturbance#23Shanb007 wants to merge 2 commits intoBetterDB-inc:masterfrom
Shanb007 wants to merge 2 commits intoBetterDB-inc:masterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3
Cluster topology graph nodes rendered tightly clustered on initial load and slowly animated apart. Additionally, clicking/dragging any single node caused all other nodes to reposition.
Changes
Pre-calculate initial node positions based on role
Increase
alphaDecay(0.0228 -> 0.05)Lower drag
alphaTarget(0.3 -> 0.01)Note
Low Risk
UI-only layout/interaction changes confined to a single visualization component; main risk is unintended node placement or responsiveness issues on resize.
Overview
Improves the initial layout and interaction stability of the
ClusterTopologyGraphby precomputing deterministic node positions (masters in a circle, replicas offset from their master) while still honoring any drag-saved positions.Tweaks the D3 force simulation to settle faster and avoid disturbing the whole graph on drag:
alphaDecayis increased and drag start uses a much loweralphaTarget; simulation “needs run” detection now keys off presence innodePositionsRefrather than missingx/y(and layout now recalculates whencontainerWidthchanges).Written by Cursor Bugbot for commit e93acfc. This will update automatically on new commits. Configure here.