Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Advanced menu item that updates the game’s options.txt to enable advanced video settings for RTX performance.
- Introduce
Update-OptionsFileto toggle or addshow_advanced_video_settings:1inoptions.txt - Add
Enable-GfxOptionsfunction and wire it to a new “Fix GFX Options” menu item - Define corresponding translation strings and enable the new menu item based on selection
Comments suppressed due to low confidence (1)
v2/installer.ps1:1234
- This attaches a click handler to the entire Advanced menu and calls Update-OptionsFile without supplying the required
-OptionsFileparameter. It should be removed, as the new menu item already has its own click handler.
$advancedMenu.Add_Click({ Update-OptionsFile })
ABUCKY0
reviewed
Jun 16, 2025
|
|
||
| function Enable-GfxOptions() { | ||
| $comMojang = [System.Environment]::GetFolderPath("LocalApplicationData") + "\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang" | ||
| $previewComMojang = [System.Environment]::GetFolderPath("LocalApplicationData") + "\Packages\Microsoft.MinecraftPreview_8wekyb3d8bbwe\LocalState\games\com.mojang" |
Member
There was a problem hiding this comment.
Is there any way we could get the path without hardcoding it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new Advanced menu item which updates options.txt to re-enable RTX in worlds.