Relax CORS allowed headers #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzane
force-pushed
the
rzane/allow-headers-cors
branch
from
f7f3981 to
063b9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_track_js_clientcurrently sendsapplication/x-www-form-urlencodedbodies. I was looking to sendapplication/jsoninstead, which is what the Dart client does. This change causes the client to send a preflight request, since the request is no longer considered "simple". The preflight request failed, since the fake server does not allow thecontent-typeheader.The real Test Track server allows all headers.
/no-platform