Open
Conversation
Contributor
sgdesmet
commented
Jan 2, 2024
sgdesmet
commented
- Ignore unknown fields as per Ignore uknown fields? #127
- Deserialize unknown enum values into their default value
github-actions
bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello and welcome! We are excited to see your first pull request and appreciate your contribution to our project. Our team is reviewing your changes and we will provide feedback as soon as possible. Thank you for taking the time to improve our project and we look forward to working with you!
Prevent webhook deserialization failing when Meta adds a field. Fixes Bindambc#127
sgdesmet
force-pushed
the
fix/ignore_unknown
branch
from
cb2eec6 to
66f3be3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
============================================
+ Coverage 86.03% 86.14% +0.11%
- Complexity 512 514 +2
============================================
Files 163 165 +2
Lines 1239 1249 +10
Branches 12 12
============================================
+ Hits 1066 1076 +10
Misses 154 154
Partials 19 19 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.