Conversation
…oogle#983) Add partial test record upload with a background uploader thread. Cleanup Add missing typing.Optional type annotations to function parameters. Fixed parsing of default arguments provided to an OpenHTF phase. Print the OpenHTF result instead of logging it. Replace marginal field in mfg-i facing protos with new MARGINAL_PASS test status. Fix bug causing data to not be uploaded when a ThreadTerminationError occurs. Marginal pass - Propagate marginal determination to the test run level. Fix a few bugs with AllInRange and add unit tests Fix bug with is_marginal check on AllInRange validator Remove circular dependency between diagnoses_lib and phase_descriptor Move check_for_duplicate_results to phase_descriptor Fix and update type annotations in diagnoses_lib Update protos to output marginal determination upstream and add console coloring for marginal output cases. Add marginal measurements. See go/openhtf-marginal-pass. Added useful debugging messages to OpenHTF unit test results when they don't pass. Add a typing.overload to execute_phase_or_test Move openhtf.measures to the phase_descriptor module Added a library to convert OpenHTF objects to strings. Update built in validators to display the spec limits in the database. Fix bug where plugs were being updated twice, resulting in tearDown being called. Update unit test docs to cover TestCase.execute_phase_or_test. Retry setsockopt when starting up the multicast thread Add a decorator-free way to write unit tests. Add capturing of instantiated plugs as an attribute on the test case. Add get_attachment_or_die method to TestApi Regenerate units with the latest UNECE publication (rec20_Rev15e-2020.xls). Raise a clear Error message when a DeviceWrappingPlug is not fully initialized Fix DUT input phase hung w/ ctrl+c (sigint). Timeout when getting multicast.send() responses from queue Add force_repeat option to force a repeat of phase up to the repeat_limit. Adding the phase name to the phase outcome logging statements. Fix type of conf when accessed as openhtf.conf Give 3 retries for timeout phase as default; Add repeat_on_timeout option for phase Replace phase_group member with either phase_sequence or phases when appropriate. Add workaround for when AbortTest plug is not initialized (this happens sometimes, but is not easily reproducible). PiperOrigin-RevId: 381093144
StationServer seems to be trying to represent (as base type) phase sequences that don't yet have their plugs initialized. This causes a warning to be logged like ``` WARNING:root:Object <class 'my.custom.htf.Plug'> is not initialized, got error _asdict() missing 1 required positional argument: 'self' ``` But has no other effect. The call stack when that warning is reached is ``` convert_to_base_types (data.py:176) <dictcomp> (data.py:199) convert_to_base_types (data.py:201) <listcomp> (data.py:204) convert_to_base_types (data.py:206) <dictcomp> (data.py:199) convert_to_base_types (data.py:201) <listcomp> (station_server.py:364) get (station_server.py:364) _execute (web.py:1702) _run (events.py:145) _run_once (base_events.py:1451) run_forever (base_events.py:438) start (asyncio.py:199) run (web_gui_server.py:157) run (station_server.py:626) _bootstrap_inner (threading.py:916) _bootstrap (threading.py:884) ``` This PR removes that warning, behaviour remains the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest OpenHTF (2.0RC?) with a quick fix to suppress warnings of "uninitialized plugs"