Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces Board Interface V2, which expands the IBoard interface to support multiple buttons and LEDs beyond the basic RGB LEDs and reset button. The changes rename the existing button getter for clarity and add support for three additional buttons (A, B, C) and three additional LEDs (A, B, C).
- Renames
getButton()togetButtonReset()to clarify it refers to the reset button - Adds three new button drivers (A, B, C) with corresponding getter methods
- Adds three new LED drivers (A, B, C) with corresponding getter methods
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/HALInterfaces/src/IBoard.h | Updates the IBoard interface to add getButtonReset(), getButtonA(), getButtonB(), getButtonC(), getLedA(), getLedB(), and getLedC() methods |
| lib/HALTargetCommon/src/Board.h | Implements the new interface methods, adds includes for the new button/LED classes, and declares member variables for the new drivers |
| lib/HALTargetCommon/src/Board.cpp | Initializes the new button and LED member variables in the constructor |
| lib/HALSim/src/Board.h | Partially updates the simulation board implementation by renaming the m_button member variable to m_buttonReset |
| lib/APPLineFollower/src/States/StartupState.cpp | Updates caller to use the renamed getButtonReset() method |
| lib/APPLineFollower/src/States/ReleaseTrackState.cpp | Updates caller to use the renamed getButtonReset() method |
| lib/APPLineFollower/src/States/ReadyState.cpp | Updates caller to use the renamed getButtonReset() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
No description provided.