This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix a test regression with pybind11 2.11.2, 2.12.1, 2.13.6+ #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“A new self._pybind11_conduit_v1_() method is automatically added to all py::class_-wrapped types, to enable type-safe interoperability between different independent Python/C++ bindings systems, including pybind11 versions with different PYBIND11_INTERNALS_VERSIONs.” https://github.com/pybind/pybind11/releases/tag/v2.13.6 Ensure that `tests/test_0_API.py::test_doc_exists` does not see this as an undocumented API function.
mgeplf
reviewed
Nov 25, 2024
Contributor
mgeplf
left a comment
mgeplf
left a comment
There was a problem hiding this comment.
Thanks; we had discussed this in another PR, but forgot to break it out into a separate request.
I will update this PR to include what was decided there.
Contributor
Author
Thanks! The changes to this PR look correct and reasonable, and I confirmed they still work for me as a downstream patch in Fedora. |
Contributor
|
Great; I will look at the build system failure at some point. |
mgeplf
approved these changes
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“A new
self._pybind11_conduit_v1_()method is automatically added to allpy::class_-wrapped types, to enable type-safe interoperability between different independent Python/C++ bindings systems, including pybind11 versions with differentPYBIND11_INTERNALS_VERSIONs.”https://github.com/pybind/pybind11/releases/tag/v2.13.6
Ensure that
tests/test_0_API.py::test_doc_existsdoes not see this as an undocumented API function.