Skip to content

A bunch of features and fixes (contains Wizzel1's scroll speed commits) [details in comment] #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alesimula wants to merge 13 commits into
base: main
Choose a base branch
from
Open

A bunch of features and fixes (contains Wizzel1's scroll speed commits) [details in comment] #6

alesimula wants to merge 13 commits into from

Conversation

@alesimula
Copy link

@alesimula alesimula commented Jul 9, 2023 •
edited
Loading

  • Include Wizzel1's scroll speed commits (but changed scrollSpeed from int to double)
  • When changing scroll direction, restart animation from current position instead of future position.
  • Change animation curve to Curves.easeOutQuart (looks more natural), speed to 2.0 and duration to 380
  • Fix trackpad gestures not working when switching between mouse wheel and trackpad
  • Fix trackpad gestures not working out of the box (it used to require a click with trackpad to work)
  • Detect locked scrollbar, default behaviour for scrollview not scrollable (e.g. when the mouse is hovering the scrollbar)

Wizzel1 and others added 13 commits January 14, 2023 13:38
@Wizzel1
Add scrollSpeed field
53393e9
@Wizzel1
Add optional animation curve field
5192c01
@Wizzel1
Bump version
e00e19a
@alesimula
Implement abrupt scroll direction change
6e46378
@alesimula
Fix mistake + animate from current position on direction change
8404d05
@alesimula
Natural web-like default smooth scrolling
69281d4
@alesimula
Fix switching between trackpad / mobile and desktop scrolling
c83efa5
@alesimula
Re-add check for limit reached in either direction
2306055
@alesimula
Fix locking when holding or hovering scrollbar
063a5a5
@alesimula
Remove log committed accidentally
9caafea
@alesimula
Fix small bug
7c82adb 
[FIX] If you scrolled while hovering the cursor on the scrollbar (scroll locked), then drag-n-drop the scrollbar somewhere else, then scroll with the mouse wheel, the scrollview would jump to the last locked location.
@alesimula
Remove commented line
f1f690b
@alesimula
Allow decimals for scrollSpeed
a749dcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alesimula @Wizzel1