Improve slightly procedure for best ploidy detection#50
Open
gladkia wants to merge 2 commits intoBoevaLab:masterfrom
Open
Improve slightly procedure for best ploidy detection#50gladkia wants to merge 2 commits intoBoevaLab:masterfrom
gladkia wants to merge 2 commits intoBoevaLab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @valeu,
First of all, thanks for your work on ControlFreeC :).
I found that it would be nice to let the user decide what should be the maximal difference between fractions of the genome explained to consider ploidy = 2 as best ploidy instead of ploidy = 4.
Also, I added the analogous code for the change from ploidy = 3 to ploidy = 2. Does it have sense from the biological perspective ?
I tested the changes on the exemplary data with slightly changed config_ctrl.txt. As the difference between the fractions of genome explained (ploidy = 4 - ploidy = 2) equals ~0.07 I was able to confirm that new code works as expected.
Best,
Arek