-
-
Notifications
You must be signed in to change notification settings - Fork 25
Support Smart-Home-Interface Part 6: Integration into Luxtronik #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbabioch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very clean and good again. From my point of view it could be merged, just pointed out some minor inconsistencies.
31f7791 to
dc80741
Compare
|
Rebased branch to the top of main |
dc80741 to
ddf0d07
Compare
|
I'd be ready for a merge. Hopefully, there shouldn't be any conflicts. I would merge this pull request first and then #213. |
Sixth (and last) pull request to gradually integrate the smart home interface. This pull request includes:
LuxtronikAllData: Combined data object from LuxtronikData and LuxtronikSmartHomeData
LuxtronikInterface: Combined interface from LuxtronikSocketInterface and LuxtronikSmartHomeInterface
Luxtronik: Expansion of the existing Luxtronik class with the Smart Home Interface
Scripts: Several scripts for maintenance/commissioning/debugging of the smart home interface
New unit-tests
Part 6 (last) for #190