Skip to content

Conversation

@Guzz-T
Copy link
Contributor

@Guzz-T Guzz-T commented Dec 23, 2025

Sixth (and last) pull request to gradually integrate the smart home interface. This pull request includes:

LuxtronikAllData: Combined data object from LuxtronikData and LuxtronikSmartHomeData
LuxtronikInterface: Combined interface from LuxtronikSocketInterface and LuxtronikSmartHomeInterface
Luxtronik: Expansion of the existing Luxtronik class with the Smart Home Interface

Scripts: Several scripts for maintenance/commissioning/debugging of the smart home interface
New unit-tests

Part 6 (last) for #190

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py251996%52, 55–59, 273–274, 279
   __main__.py23230%3–52
   calculations.py24675%327, 335, 340–343
   datatypes.py330199%115
   discover.py58198%62
   parameters.py21195%1212
   visibilities.py12192%403
luxtronik/scripts
   __init__.py16160%3–28
   discover_shi.py60600%8–98
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
   dump_shi.py19190%7–40
   performance_shi.py63630%7–89
   watch_shi.py38380%7–85
TOTAL210430785% 

Tests Skipped Failures Errors Time
314 0 💤 0 ❌ 0 🔥 8.992s ⏱️

Copy link
Collaborator

@kbabioch kbabioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very clean and good again. From my point of view it could be merged, just pointed out some minor inconsistencies.

@Guzz-T Guzz-T force-pushed the issue/190/integration branch from 31f7791 to dc80741 Compare December 27, 2025 17:28
@Guzz-T
Copy link
Contributor Author

Guzz-T commented Dec 27, 2025

Rebased branch to the top of main

@Guzz-T Guzz-T force-pushed the issue/190/integration branch from dc80741 to ddf0d07 Compare December 27, 2025 17:33
@kbabioch
Copy link
Collaborator

Are we good to merge here from your point of view @Guzz-T? Not sure how this will work out with #213. Should we first merge this one (#207) and see if there will be conflicts?

@Guzz-T
Copy link
Contributor Author

Guzz-T commented Dec 29, 2025

I'd be ready for a merge. Hopefully, there shouldn't be any conflicts. I would merge this pull request first and then #213.

@kbabioch kbabioch merged commit c3d5f95 into Bouni:main Dec 30, 2025
4 checks passed
@Guzz-T Guzz-T deleted the issue/190/integration branch December 30, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants