-
-
Notifications
You must be signed in to change notification settings - Fork 26
Update smart home interface according to (in)official documentation #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Great find, finally we have a official documentation of this interface. At least as official as it will get. |
|
I just noticed that there is more to do here. I'll get back to you as soon as I'm done. |
|
I've put it into |
| "index": 5, | ||
| "count": 1, | ||
| "names": ["hot_water_mode"], | ||
| "names": ["hot_water_mode", "dhw_mode"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you prefer hot_water or dhw, or both?
(the same applies to similar changes)
…umentation See zip-file download at https://www.alpha-innotec.com/de/produkte/zubehor/smart-home---apps/knx-schnittstelle Note: The min/max values now relates to the raw value
…r string value Mainly to treat "x" and "Unknown_x" as equivalent.
…rs correctly For example, 4-byte integer values are stored in two 2-byte registers with bit index 31..16 in the first register and 15..0 in the second register.
Due to the register size, the smart home interface often uses 16-bit signed values (for temperatures, ...).
This data type can handle values where each bit has a specific meaning.
…(in)official documentation
d851d0b to
61da6b8
Compare
|
The pull request now contains a large number of changes. However, all of them have been added based on new findings from the documentation. Would you prefer to split these changes across several pull requests? |
See zip-file download at https://www.alpha-innotec.com/de/produkte/zubehor/smart-home---apps/knx-schnittstelle
Note: The min/max values now relates to the raw value