Add config entry support to Splunk integration #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#159604) Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com>
…ns (home-assistant#159375) Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: Joostlek <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joostlek <joostlek@outlook.com>
Co-authored-by: Joostlek <joostlek@outlook.com>
…59768) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
…60436) Co-authored-by: Joostlek <joostlek@outlook.com>
…#160435) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
…ome-assistant#160430) Co-authored-by: Joostlek <joostlek@outlook.com>
…ant#160404) Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
This commit adds UI configuration flow support to the Splunk integration, upgrading it from legacy quality scale to Bronze tier. Major changes: - Add config_flow.py with user setup, reauth, and YAML import flows - Update __init__.py to support both config entries and legacy YAML with filters - Add proper error handling distinguishing connection vs auth failures - Implement automatic reauth flow on token expiration - Preserve YAML configuration support for entity filter functionality - Add repair issues for YAML deprecation warnings - Create comprehensive test suite with 100% coverage - Update manifest.json to enable config_flow and Bronze quality scale Implementation details: - Separates connectivity checks from token validation for better error messages - ConfigEntryNotReady for connection issues, ConfigEntryAuthFailed for auth - YAML configs without filters are auto-imported to config entries - YAML configs with filters continue working (entity filters not supported in UI) - Event listener properly handles errors without crashing integration - Unauthorized errors trigger reauth flow automatically Testing: - Full test coverage for config flow (user, import, reauth) - Tests for all error conditions and edge cases - Integration setup and unload tests - YAML import tests for both filter and non-filter scenarios Based on PR home-assistant#101679 with maintainer feedback addressed.
- Fix line length violations (max 88 chars) - Split long import statement in __init__.py - Break up long lines in config_flow.py validation - Fix function signature line length in test_init.py All Python files now comply with line length requirements.
…cale - Remove integration_type from manifest.json - Revert quality_scale from bronze back to legacy - Remove quality_scale.yaml file As per review feedback in PR home-assistant#160478
Bre77
force-pushed
the
claude/splunk-config-entry-support-tjMx7
branch
from
72e5a71 to
db97fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds UI configuration flow support to the Splunk integration,
upgrading it from legacy quality scale to Bronze tier.
Major changes:
Implementation details:
Testing:
Based on PR home-assistant#101679 with maintainer feedback addressed.