Draft
Conversation
TODO: Get all yaw offsets to agree and eliminate the unneeded sliders
- Deal with reload blocks - Deal with deploy
- Fix laser missile PD behavior - Set targetVessel to guardTarget if null in the None and Default -> Bomb cases
- Account for yawStandbyAngle - Complete deploy mechanics - Favor remaining on the current turret for equal priority cases (except when the new turret in question is the active turret) - Fix bug in yawStandbyAngle implementation for parts with multiple turrets
- Set up functions to handle stowing turrets in edge case, though for now testing seems to indicate this is unnecessary
- Fix issues where turret audio would error into NaN
- MML MissileReferenceTransform was getting set to transforms that were likely dummies, resulting in incorrect MissileReferenceTransform readings
- MMR was using ammoCount for GetModuleMass and GetModuleCost resulting in double-counting the mass and cost of missiles in magazines, which already account for this.
- Previously this would be limited to MAX_GUARD_VISUAL_RANGE instead of being unlimited as reported in the menu, resulting in confusion
Time check should be >= rather than just >
- Use 2 * dataCount for MWS, launchWarnings and missileLockData - Reduce missileLockData slot usage by reducing MissileLockLife by fixedDeltaTime
- Just use GetHeatTarget skipping the whole SearchForHeatTarget logic, *assume* we can somehow point the missile towards the target
- Because PD is separate from standard Guard functionalities, the various "SearchFor" functions don't actually work as intended when GMR is firing a PD missile
- Re-organize envelope checks - Add more telemetry to RadarLOAL
- Fix missing coroutine calls
BrettRyland
reviewed
Mar 2, 2026
| { | ||
| pingsData = new RWRSignatureData[dataCount]; | ||
| MWSData = new RWRSignatureData[dataCount]; | ||
| MWSData = new RWRSignatureData[2 *dataCount]; |
Owner
There was a problem hiding this comment.
What's the reasoning for these being 2 * dataCount as opposed to some other length?
(I don't really understand what you're using these for, but hard-coded array sizes are suspicious.)
| [KSPField] public bool activeMissileOnly = false; | ||
|
|
||
| MissileFire WeaponManager | ||
| public MissileFire WeaponManager |
Owner
There was a problem hiding this comment.
Why public? This isn't getting called externally.
| Ray ray = new Ray(transform.position, vectorToTarget); | ||
| bool pingRWR = Time.time - lastRWRPing > (0.5f * RadarUtils.ACTIVE_MISSILE_PING_PERSIST_TIME); | ||
| if (pingRWR) lastRWRPing = Time.time; | ||
| bool pingRWR = Time.fixedTime - lastRWRPing > (RadarUtils.ACTIVE_MISSILE_PING_PERISTS_TIME); |
Owner
There was a problem hiding this comment.
The spelling for "PERSIST" was corrected in Josue's previous PR, which also added the 0.5f factor (it was previously 2f). Presumably the 0.5f factor is intentional, so it might be best to check with Josue for why it's there.
| missileLauncher.reloadableRail = missileSpawner; | ||
| missileLauncher.hasAmmo = true; | ||
| missileLauncher.multiLauncher = this; | ||
| missileLauncher.MissileReferenceTransform = part.FindModelTransform("missileTransform"); |
Owner
There was a problem hiding this comment.
Removing this preference for "missileTransform" doesn't break any known existing parts does it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.