feat: Offline payments with manual approval #143

rehanrehman389 · 2026-01-27T18:12:04Z

#134

https://drive.google.com/file/d/1_Ofiood6A57pCYD98SMCpaqZ3UgL9NdE/view?usp=sharing

rehanrehman389 · 2026-01-27T18:19:16Z

@NagariaHussain Please review the PR and confirm if our understanding of the requested feature is aligned.

NagariaHussain · 2026-01-27T18:50:36Z

Instead of "UPI payment" we have to make it generic.

"Enable Off-platform payments"
Collect proof of payment can be a checkbox (which shows the attach and links to booking)
A new payment status field in booking to track "Unpaid", "Paid", "Verification Pending", etc. Maybe even a status field? (We might want to track booking status: Confirmed, Approval Pending, Approved, Rejected).
Buzz Custom Field support in the off-platform payments dialog
If both online payment gateway and off platform payments are enabled, we show the option in the multi payment gateway dialog (user can control what the label is: e.g. "UPI Payment" etc.

rehanrehman389 · 2026-02-03T19:29:02Z

@NagariaHussain i will rebase and add unit test

NagariaHussain · 2026-02-04T11:49:46Z

Can you update the video and also add relevant screenshots?

rehanrehman389 · 2026-02-04T18:05:38Z

https://drive.google.com/file/d/1VZ4Th8Ufq5Oy66NydrGdcqbmhsWtVc_Z/view?usp=sharing

NagariaHussain · 2026-02-05T15:08:52Z

Instead of these 3 fields, let's just make it a HTML editor field, the user should be free to show any type of content they want (QR code they can paste too). E.g. Bank details, etc.

dashboard/src/pages/BookTickets.vue

NagariaHussain · 2026-02-05T15:31:39Z

Check failing tests.

rehanrehman389 · 2026-02-09T18:57:37Z

@NagariaHussain good to merge?

NagariaHussain · 2026-02-10T00:38:22Z

Can you add unit and e2e tests @rehanrehman389 ?

rehanrehman389 · 2026-02-10T03:33:34Z

Yes

rehanrehman389 · 2026-02-10T14:30:45Z

@NagariaHussain

rehanrehman389 · 2026-02-10T14:44:15Z

@NagariaHussain https://drive.google.com/file/d/153h5EpTZq9LXevT1SRSioPqqm8XPoxzv/view?usp=sharing

UmakanthKaspa · 2026-02-10T17:38:38Z

@rehanrehman389
Bug: Tickets are generated and accessible even when booking is "Approval Pending" or "Rejected"

When booking with off-platform payment:

Booking shows "Approval Pending" → but tickets are already generated with QR codes
Booking is "Rejected" → tickets still exist and user can access them from "My Tickets"
Ticket email and Zoom registration happen immediately before organizer verifies payment

Expected:

Tickets should only be generated after the organizer clicks Approve
On Reject, no tickets should exist (cancelled)
Email should be sent only when booking is approved

UmakanthKaspa · 2026-02-10T17:46:18Z

@rehanrehman389
Minor: Off-platform payment dialog doesn't adapt to dark theme.

@NagariaHussain what do u think do free tickets need approval?

UmakanthKaspa · 2026-02-10T17:55:06Z

Bug: Guest booking with OTP + off-platform payment is broken

When event has both guest booking (with Email/Phone OTP) and off-platform payment enabled:

Off-platform dialog opens and submits without OTP verification
Backend rejects with "Verification code is required"
Guest booking with verification "None" + off-platform works fine

Root cause: In BookingForm.vue, the off-platform check (line 1128) runs before the OTP check (line 1152), so OTP is skipped.

Expected: OTP verification should happen before showing the off-platform payment dialog.

NagariaHussain · 2026-02-10T18:14:51Z

The booking should not have been submitted until approved.

rehansari26 · 2026-02-11T09:45:08Z

The booking should not have been submitted until approved.

So we dont need any custom button here to approve or reject right? @NagariaHussain
User will select manually status as Reject or Approved?

NagariaHussain · 2026-02-11T17:13:48Z

As discussed, on approve it will set the status to approved (before submit) and submit.

…orrectness - Extract OFF_PLATFORM_PAYMENT_METHOD and OFF_PLATFORM_DEFAULT_LABEL constants - Replace insecure inference (missing payment_gateway) with explicit is_off_platform flag - Extract isOffPlatformGateway() helper in BookingForm to replace 3 inline checks - Remove redundant default label fallbacks in frontend (trust backend) - Fix misleading hasattr check in before_submit - Remove dead off_platform_custom_fields from payload - Remove console.log from OffPlatformPaymentDialog - Remove phantom attached_to_field reference - Add prose-sm class for HTML payment details rendering Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ultiple gateways The non-guest submit path was missing the multi-gateway check, causing it to always pick the first gateway (Razorpay) and skip the selection dialog when both Razorpay and off-platform payment were enabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Reduce padding on payment details div (p-4 → p-3) to prevent double indentation from parent container - Add block and mb-2 to Payment Proof label matching SponsorshipDetails pattern Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use file_name (original filename) instead of name (Frappe doc ID hash). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Strip prose-sm first-child margin-top that caused extra padding above the payment details text - Replace text checkmark with LucideCheckCircle icon for file upload success message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…odebase Simplifies naming: Off-platform → Offline. Renames DocType fields, Python constants, Vue components, E2E tests, and Buzz Custom Field applied_to value ("Offline Payment Form"). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update section description to better explain offline payments. Show "Replace" button text after payment proof is uploaded instead of "Upload File". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Offline bookings now stay as draft (docstatus=0) instead of being submitted immediately. Tickets are only generated when an Event Manager approves the booking. This prevents premature ticket generation for unverified offline payments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…reject buttons - before_submit now throws if someone tries to manually submit an offline payment booking, directing them to use Approve or Reject instead - Approve and Reject buttons are now top-level (no longer hidden in Actions dropdown) with primary/danger styling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

rehanrehman389 added 6 commits February 5, 2026 02:09

feat: UPI/QR payment support (manual verification)

36315db

chore: replace UPI with generic off-platform payments

e242a26

fix: add optional payment proof upload

e8a16e2

feat: payment and booking status field

b1ae6d1

feat: add custom fields support for off-platform payments

9bac883

feat: add custom labels for off-platform payments

90788ad

rehanrehman389 force-pushed the upi-payment branch 4 times, most recently from 3b16ca6 to fae3ae1 Compare February 5, 2026 03:42

NagariaHussain requested changes Feb 5, 2026

View reviewed changes

dashboard/src/pages/BookTickets.vue Outdated Show resolved Hide resolved

rehanrehman389 force-pushed the upi-payment branch 2 times, most recently from d221640 to df8408c Compare February 9, 2026 15:09

fix: resolve issues after rebase

3ab0471

rehanrehman389 force-pushed the upi-payment branch from df8408c to 3ab0471 Compare February 9, 2026 16:57

refactor: replace off-platform payment fields with HTML editor

eba3963

rehanrehman389 force-pushed the upi-payment branch from a5675f9 to eba3963 Compare February 9, 2026 18:41

Merge branch 'main' into upi-payment

cacd63c

fix: resolve conflict

4cafa50

feat: off-platform unit test cases

0c5e89c

rehanrehman389 added 2 commits February 11, 2026 15:53

refactor: use Text Editor for off-platform payment details

7eed975

fix: ensure OTP verification before off-platform payment dialog

469c489

NagariaHussain and others added 9 commits February 12, 2026 00:34

Merge branch 'main' into upi-payment

0d3bdff

fix: show original filename after payment proof upload

00a90f0

Use file_name (original filename) instead of name (Frappe doc ID hash). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: improve offline payment section description and upload UX

48f0f69

Update section description to better explain offline payments. Show "Replace" button text after payment proof is uploaded instead of "Upload File". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: disable confetti for offline payment bookings pending approval

ca9ec9e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

NagariaHussain changed the title ~~feat: UPI/QR payment support (manual verification)~~ feat: Offline payments with manual approval Feb 11, 2026

NagariaHussain and others added 5 commits February 12, 2026 01:30

fix: buttons

75c7b8d

fix: discard booking on rejection instead of keeping as draft

2e876b6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: use inline refresh icon for payment proof replace action

dfa9ec9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

NagariaHussain approved these changes Feb 11, 2026

View reviewed changes

NagariaHussain and others added 3 commits February 12, 2026 01:49

chore: add nosemgrep comment for process_booking guest whitelist

a6b9f62

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: show actual payment status in booking financial summary

55918b9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: add patch to set payment status for existing submitted bookings

338bc19

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

NagariaHussain merged commit 34e970c into BuildWithHussain:main Feb 11, 2026
4 checks passed

feat: Offline payments with manual approval #143

feat: Offline payments with manual approval #143

Conversation

rehanrehman389 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rehanrehman389 commented Jan 27, 2026

Uh oh!

NagariaHussain commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rehanrehman389 commented Feb 3, 2026

Uh oh!

NagariaHussain commented Feb 4, 2026

Uh oh!

rehanrehman389 commented Feb 4, 2026

Uh oh!

NagariaHussain commented Feb 5, 2026

Uh oh!

Uh oh!

NagariaHussain commented Feb 5, 2026

Uh oh!

rehanrehman389 commented Feb 9, 2026

Uh oh!

NagariaHussain commented Feb 10, 2026

Uh oh!

rehanrehman389 commented Feb 10, 2026

Uh oh!

rehanrehman389 commented Feb 10, 2026

Uh oh!

rehanrehman389 commented Feb 10, 2026

Uh oh!

UmakanthKaspa commented Feb 10, 2026

Uh oh!

UmakanthKaspa commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UmakanthKaspa commented Feb 10, 2026

Uh oh!

NagariaHussain commented Feb 10, 2026

Uh oh!

rehansari26 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NagariaHussain commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rehanrehman389 commented Jan 27, 2026 •

edited

Loading

NagariaHussain commented Jan 27, 2026 •

edited

Loading

UmakanthKaspa commented Feb 10, 2026 •

edited

Loading

rehansari26 commented Feb 11, 2026 •

edited

Loading