feat: add MinIO to CI for end-to-end object storage testing #19
+427
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the need for real Cloudflare R2 credentials in CI by running MinIO as a local S3-compatible store. This enables full upload/download E2E testing. - Add VMS_S3_ENDPOINT_URL env var override in vms/r2.py - Add vms/seed.py with seed_test_settings() for CI configuration - Add MinIO docker container + bucket setup to both CI workflows - Add upload/download E2E helpers to e2e/helpers/vms.ts - Add e2e/tests/uploads.spec.ts with 8 upload flow tests https://claude.ai/code/session_01TNbF7ZZFmi5Ckz1dJPLTm7
Port 9000 is used by Frappe's socketio server, causing bench start to hang. https://claude.ai/code/session_01TNbF7ZZFmi5Ckz1dJPLTm7
bench execute auto-commits, manual commit is unnecessary. https://claude.ai/code/session_01TNbF7ZZFmi5Ckz1dJPLTm7
VMS Settings restricts uploads to video formats (mp4, mov, etc.). Tests were using .txt files which get rejected by the extension validator. https://claude.ai/code/session_01TNbF7ZZFmi5Ckz1dJPLTm7
NagariaHussain
deleted the
claude/minio-ci-e2e-testing-01TNbF7ZZFmi5Ckz1dJPLTm7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the need for real Cloudflare R2 credentials in CI by running MinIO as a local S3-compatible store. This enables full upload/download E2E testing.
https://claude.ai/code/session_01TNbF7ZZFmi5Ckz1dJPLTm7