Skip to content

Remove hardcoded DeepSeek-OCR model default value #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove hardcoded DeepSeek-OCR model default value #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c1455
Initial plan
Copilot Dec 15, 2025
61e3587
移除 DeepSeek-OCR 模型名称硬编码默认值
Copilot Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,7 @@ class DeepSeekOCRConfig(BaseSettings):
default="https://api.siliconflow.cn/v1",
description="DeepSeek-OCR API Base URL"
)
model: str = Field(
default="deepseek-ai/DeepSeek-OCR",
description="DeepSeek-OCR Model Name"
)
model: str = Field(..., description="DeepSeek-OCR Model Name")
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the model field required creates an inconsistency with other configuration classes in this codebase. LLMConfig (line 24), EmbeddingConfig (line 46-49), and RerankConfig (line 74-77) all provide default values for their model fields.

This inconsistency means that:

  1. Users must explicitly set DS_OCR_MODEL or the application will fail to start
  2. Other services can start with sensible defaults even if their model env vars are missing
  3. The configuration pattern is not uniform across the codebase

Consider either:

  • Keeping the default value to maintain consistency with other configs
  • Or updating all other config classes to also require explicit model specification (if that's the desired pattern)
Suggested change
model: str = Field(..., description="DeepSeek-OCR Model Name")
model: str = Field(default="deepseek-ocr-base", description="DeepSeek-OCR Model Name")

Copilot uses AI. Check for mistakes.

# OCR 模式配置
default_mode: str = Field(
Expand Down