Skip to content

Comments

Allow start time configuration per pool#24

Open
0xSkly wants to merge 2 commits intoByte-Masons:masterfrom
beethovenxfi:feature/allow-start-time-per-pool
Open

Allow start time configuration per pool#24
0xSkly wants to merge 2 commits intoByte-Masons:masterfrom
beethovenxfi:feature/allow-start-time-per-pool

Conversation

@0xSkly
Copy link

@0xSkly 0xSkly commented Sep 26, 2022

This would allow to configure a start timestamp for a pool on which maturing would start. This (together with a 0 allocation level 0 config) would allow for a more fair deployment of new pools, giving people the chance to join before emissions & maturing start.

It seems like this requires rather minimal changes but good chance I miss some downstream effects of this change.

@0xSkly
Copy link
Author

0xSkly commented Sep 26, 2022

Question would be if it should overwrite the pool.allocPoint to 0 if block.timestamp < pool.startTime to not start emissions before. You could kinda achieve the same with setting the level 0 to 0 allocation and min maturity for level 1 to something like 1 second so you move into level 1 as soon as startTime passed. but then the pool would already allocate rewards before startTime which would not be ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant