review of ramses double staking changes vs velo gauges#41
review of ramses double staking changes vs velo gauges#41imrtlfarm wants to merge 4 commits intov2-velo-gauge-audit-fixesfrom
Conversation
imrtlfarm
left a comment
imrtlfarm
left a comment
There was a problem hiding this comment.
main concern left is why we dont loop thru multi rewards on the velo side. do they not exist?
| @@ -1,268 +1,119 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.0; | |||
| pragma solidity =0.7.6 || ^0.8.13; | |||
| } | ||
| // Deposit the LP in the gauge | ||
| IGauge(pool.gauge).deposit(balance); | ||
| IGauge(pool.gauge).deposit(balance, 0); |
There was a problem hiding this comment.
why is tokenid hardcoded to 0?
There was a problem hiding this comment.
skips NFT-voter-gauge attachment part, makes sense
|
|
||
| // claim rewards before disabling gauge | ||
| if (_claimRewards) { | ||
| IGauge(gauge).getReward(address(this)); |
There was a problem hiding this comment.
How come we do not loop thru rewards in the velo version???
| _rewardTokensArray[0] = _rewardTokens; | ||
| voter.claimRewards(gauges, _rewardTokensArray); | ||
|
|
||
| IERC20 rewardToken = IERC20(gauge.rewardToken()); |
There was a problem hiding this comment.
same as above why no looping here?
| test = 'test/foundry' | ||
| cache_path = 'forge-cache' | ||
| script = 'scripts' | ||
| evm_version = 'shanghai' |
There was a problem hiding this comment.
this will brick us on non-push0 chains. Optimism and arbitrum have push0. superchains like mode and fraxtal should. Mantle and most other chains should also have this but it still prob doesn't make sense to set to shanghai
There was a problem hiding this comment.
ramses' deployed contract bytecode didnt have push0, throwing errors
2 participants
No description provided.