Add implementation of standard deviation on data#1
Open
Conversation
tgermany20
reviewed
Jun 20, 2024
|
|
||
| def s_dev(data): | ||
| """Computes and returns standard deviation for data.""" | ||
| mmm = np.mean(data, axis=0) |
There was a problem hiding this comment.
Looks good, no changes from me. Maybe more comments in code
tgermany20
reviewed
Jun 20, 2024
inflammation-analysis.py
Outdated
| for filename in InFiles: | ||
| inflammation_data = models.load_csv(filename) | ||
|
|
||
| view_data = {'average': models.daily_mean(inflammation_data), 'max': models.daily_max(inflammation_data), 'min': models.daily_min(inflammation_data)} |
There was a problem hiding this comment.
Possible test to complete, test standard deviation for one patient with multiple observations.
tgermany20
suggested changes
Jun 20, 2024
| @@ -27,7 +27,8 @@ def main(args): | |||
| for filename in InFiles: | |||
There was a problem hiding this comment.
Test standard deviation for two patients.
Owner
Author
There was a problem hiding this comment.
Brilliant, I'll raise this as an issue on my repo for future work when I work out how.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a pull request