Skip to content

Conversation

@bartblaze
Copy link
Contributor

Refactored ransomware extension classes and added a generic extension detection class. Should resolve #512

Refactored ransomware extension classes and added a generic extension detection class.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bartblaze, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ransomware extension detection logic by separating specific, known ransomware family extensions from more generic ones. This change improves the modularity and maintainability of the detection signatures, allowing for more precise identification of known threats while also providing a dedicated mechanism for catching broader, less specific ransomware activity. The refactoring also addresses issue #512.

Highlights

  • Class Renaming: The primary ransomware extension detection class has been renamed from "RansomwareExtensions" to "RansomwareExtensionsKnown" for improved clarity and distinction.
  • Generic Extension Extraction: Generic ransomware file extension patterns (e.g., ".encrypt", ".locked", ".encrypted") have been removed from the "RansomwareExtensionsKnown" class.
  • New Generic Detection Class: A new signature class, "RansomwareExtensionsGeneric", has been introduced to specifically detect common, generic ransomware file extensions.
  • Threat Intelligence Mapping: The new generic detection class includes MITRE ATT&CK (TTPs) and MBC (micro-behaviors) references for enhanced threat intelligence mapping.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ransomware extension detection by separating known, family-specific extensions from generic ones into a new RansomwareExtensionsGeneric class. This is a good architectural improvement. My review focuses on the newly introduced RansomwareExtensionsGeneric class, where I've found a significant correctness issue in the regular expression patterns that could lead to false positives, and a couple of opportunities to improve code readability and robustness. I've provided code suggestions to address these points.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@doomedraven doomedraven merged commit 169b894 into CAPESandbox:master Dec 15, 2025
2 checks passed
@doomedraven
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ransomware_fileextensions signature causes malware to be detected & classified as "multi-family"

2 participants