Skip to content

chore: Refactor IxaError to use thiserror#768

Open
cdc-as81 wants to merge 1 commit intomainfrom
cdc-as81-refactor-IxaError-to-use-thiserror
Open

chore: Refactor IxaError to use thiserror#768
cdc-as81 wants to merge 1 commit intomainfrom
cdc-as81-refactor-IxaError-to-use-thiserror

Conversation

@cdc-as81
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Benchmark Results

Hyperfine

| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|:---|---:|---:|---:|---:|
| `large_sir::baseline` | 3.0 ± 0.0 | 2.9 | 3.1 | 1.00 |
| `large_sir::entities` | 12.1 ± 0.2 | 11.9 | 13.0 | 4.07 ± 0.10 |

Criterion

Regressions:
  Group                                  Bench                                                              Change  CI Lower  CI Upper
  -------------------------------------  ----------------------------------------------------------------  -------  --------  --------
  indexing                               with_query_results_multiple_individually_indexed_properties_enti   2.511%    2.139%    3.117%
  indexing                               query_people_indexed_multi-property_entities                      15.711%   15.104%   16.271%
  indexing                               with_query_results_single_indexed_property_entities                0.631%    0.030%    1.391%
  indexing                               query_people_multiple_individually_indexed_properties_entities     3.120%    2.670%    3.695%
  indexing                               query_people_count_indexed_multi-property_entities                 0.698%    0.110%    1.220%
  sample_entity_multi_property_indexed   10000                                                              0.792%    0.281%    1.271%
  sample_entity_multi_property_indexed   100000                                                             1.648%    0.987%    2.364%
  sample_entity_multi_property_indexed   1000                                                               1.060%    0.516%    1.699%
  large_dataset                          bench_query_population_property_entities                           2.001%    0.355%    3.700%
  large_dataset                          bench_match_entity                                                20.769%   20.170%   21.493%
  large_dataset                          bench_query_population_multi_indexed_entities                      5.522%    4.869%    6.192%
  large_dataset                          bench_query_population_derived_property_entities                   6.903%    5.445%    8.074%
  sampling                               sampling_multiple_l_reservoir_entities                             8.029%    7.668%    8.376%
  sampling                               sampling_single_l_reservoir_entities                              10.382%    9.674%   10.856%

Improvements:
  Group                                  Bench                                                              Change  CI Lower  CI Upper
  -------------------------------------  ----------------------------------------------------------------  -------  --------  --------
  sample_entity_single_property_indexed  10000                                                             -1.286%   -1.682%   -0.838%
  sample_entity_single_property_indexed  100000                                                            -3.409%   -3.691%   -3.097%
  sample_entity_single_property_indexed  1000                                                              -1.821%   -2.606%   -1.177%
  indexing                               query_people_count_single_indexed_property_entities               -0.858%   -1.560%   -0.317%
  indexing                               with_query_results_indexed_multi-property_entities                -3.239%   -3.855%   -2.761%
  indexing                               query_people_count_multiple_individually_indexed_properties_enti  -1.995%   -2.140%   -1.880%
  sampling                               sampling_multiple_known_length_entities                           -3.059%   -3.501%   -2.524%
  sample_entity_whole_population         10000                                                             -2.391%   -2.842%   -1.979%
  sample_entity_whole_population         100000                                                            -3.255%   -4.309%   -2.452%
  sample_entity_whole_population         1000                                                              -2.200%   -2.638%   -1.865%

Unchanged:
  Group                                  Bench                                                              Change  CI Lower  CI Upper
  -------------------------------------  ----------------------------------------------------------------  -------  --------  --------
  indexing                               query_people_single_indexed_property_entities                      0.146%   -0.474%    0.954%
  large_dataset                          bench_filter_indexed_entity                                        0.411%  -11.917%   14.851%
  large_dataset                          bench_filter_unindexed_entity                                     -0.117%   -4.890%    4.803%
  large_dataset                          bench_query_population_multi_unindexed_entities                    0.520%   -0.276%    1.259%
  large_dataset                          bench_query_population_indexed_property_entities                   0.318%   -0.451%    1.033%
  sampling                               sampling_single_known_length_entities                             -0.411%   -1.220%    0.303%

@cdc-as81 cdc-as81 linked an issue Feb 13, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor IxaError to use thiserror

1 participant