Allow Kafka to be shared outside of ODE Network#225
Merged
John-Wiens merged 1 commit intodevelopfrom Nov 12, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
The Bitnami Kafka images used by the ODE only advertise a small selection of ports to listen for new data from applications. This is set in the jpo-utils docker-compose-kafka.yml file here
Specifically: KAFKA_CFG_ADVERTISED_LISTENERS: "PLAINTEXT://kafka:9094,EXTERNAL://${KAFKA_BOOTSTRAP_SERVERS:-kafka:9092}"
In the default configuration, this causes the Kafka broker to advertise to connected applications that they should send data to Kafka:9092. For applications such as the ADM and AEM modules this works fine, as they are typically deployed alongside the ODE itself and using a container ID of Kafka will properly route back to the Bitnami container. However, this strategy fails if another container or application outside of the Docker-compose Network tries to connect. For example, spinning up a separate copy of the geojson converter will fail since it cannot route properly back to the hostname Kafka.
This PR solves this issue by directly specifying the KAFKA_BOOTSTRAP_SERVERS env var. This changes the default advertised broker location to be DOCKER_HOST_IP:9092 which is typically routable by external containers.