Key listener refactor #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwhite1996
approved these changes
Apr 16, 2018
Contributor
gwhite1996
left a comment
gwhite1996
left a comment
There was a problem hiding this comment.
This works more smoothly than the KeyListener I had made. The only issue I could find is that the orc should stand still while firing. Arvin already made this change in the ModelUpdateRefactor so it's a simple fix.
rlyshw
suggested changes
Apr 16, 2018
Contributor
rlyshw
left a comment
rlyshw
left a comment
There was a problem hiding this comment.
Resolve merge conflict in the model
Author
|
I got rid of the merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a keyListener and took it out of the model so now no logic is happening in the model.