Conversation
- Shifted existing function `encoder_convexity` to `skinner_encoder_convexity` - Changed `encoder_convexity` to use weighted sum of priors - Added/modified tests to now check for explicit differences between `encoder_convexity` and `skinner_encoder_convexity`
- Fixed issue where struct would not throw error of priors was less than 1 - Added test to ensure this edge case is now covered
- Adds extra error messages to catch zero rows in qwm, which cause errors - Adds extra testing to ensure the edge case is caught
shanest
approved these changes
Jul 21, 2025
Contributor
shanest
left a comment
shanest
left a comment
There was a problem hiding this comment.
Looks great! Thanks Ash. Only small thing (but not going to make it a blocker) is that in the future I think we'll probably just want to remove skinner_encoder_convexity altogether (possibly with a comment to her repo for good measure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encoder_convexitytoskinner_encoder_convexityencoder_convexityto use weighted sum of priorsencoder_convexityandskinner_encoder_convexity