Conversation
- Includes program files needed to run the experiments - Includes documentation which explains how to run the experiments - TODO: Finish up the documentation once issues have been addressed - Includes minimized `.csv` files for easy data processing - Does not include larger model files nor data which is used from other projects - Documentation does include details on how to get all of this data
shanest
left a comment
shanest
left a comment
There was a problem hiding this comment.
Great stuff Ash! A few little things here and there, basically all down to code style type of things
|
|
||
| ## How To Run | ||
|
|
||
| ### Installing The Data |
There was a problem hiding this comment.
I'd put little scripts in the data folder for downloading these files via curl
There was a problem hiding this comment.
For the OSF data I am not exactly sure how to download all of the files dynamically, do you have any examples that I could look at? For the others I should be able to create something.
There was a problem hiding this comment.
Good point! Not sure off the top of my head, but just pointing to the OSF repo in README will be enough ehere
| closest = get_closest(points, p, amount + 1) | ||
| for c in closest: | ||
| if i < 1501: | ||
| c += 1501 |
There was a problem hiding this comment.
Its because since points along the optimal frontier compare to a list which does not contain the optimal values, the index from that list needs to have 1501 (the number of optimal points) added to it to get the proper point. When making changes I will go and move this value into a variable and either calculate it on the fly or have a constant somewhere.
| import pandas as pd | ||
|
|
||
|
|
||
| def csv_to_latex(file_name): |
There was a problem hiding this comment.
pandas has a .to_latex method in DataFrame; is there a reason not to use that?
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_latex.html
There was a problem hiding this comment.
Oh, I didn't know about that function. I will take a look and see if I am able to use it.
There was a problem hiding this comment.
Looking at this now I think that since it already exists and is pre-formatted for the paper the existing function works better, since it has the horizontal lines and the actual full table, as opposed to the .to_latex function, which while similar, does not have those things specifically (Also custom column names, but that would not take too long to implement)
There was a problem hiding this comment.
I think the "booktabs" option in to_latex does most of what you want, but yeah, happy to stick with your custom one since it makes exactly what you want :)
…ect questions about - Added argument and return types - Added docstrings - Fixed bugs across various files - Cleaned up code across various files - Added arguments to color generation - Changed how the minimized model files are generated - Added requirements file - Added downloading script - Work in progress, to add to README - Various other changes
|
Thanks, Ash! Going to merge; left a few small comments that we can keep in mind for future iterations, but nothing very major or important at all |
2 participants
.csvfiles for easy data processing