Conversation
kjohnsen
requested changes
Mar 12, 2025
Contributor
kjohnsen
left a comment
kjohnsen
left a comment
There was a problem hiding this comment.
Looks like the built docs got removed. Could you fix that? Really, we shouldn't be tracking the built docs, only the source. It's lower priority, so let's postpone it for now, but on the roadmap I added tasks for improving the docs more by building them with GitHub actions.
Contributor
|
The diff is pretty big, removing all those files and adding them back in. Could we try this again straight from the master branch? This is just a guess since I don't know rebase that well, but maybe branch from here, then rebase onto master, and open a PR with that new branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.