Revamp atomic region inference pass to support the latest LLVM and fix/refactor code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor code Below are the key changes: - Use LLVM's new pass manager, a major improvement from the legacy one. - Fix a shortcoming of the inference algorithm to actually collect all uses of a fresh/consistent variable. - Optimize the inference cleanup algorithm to remove all instructions associated with the arguments of fresh/consistent annotations. - Thoroughly log debug messages throughout the components of the pass for a clearer view of the process. - Rename files, structs, functions, variables, etc. to be more descriptive and consistent. - General code style refactoring (e.g., use `auto` and structured bindings (destructuring) where possible). - Added simple C tests to `benchmarks/ctests`.
robertzhidealx
changed the title
robertzhidealx
changed the title
robertzhidealx
changed the title
Author
|
My original intention was to merge into a separate branch ( @msurbatovich May I ask if I could be given some access rights? Otherwise, could you please help create a |
robertzhidealx
changed the title
robertzhidealx
commented
Nov 21, 2023
| #endif | ||
| v.emplace(inst); | ||
|
|
||
| //* Actually collect all uses (e.g., log(x)) |
robertzhidealx
commented
Nov 21, 2023
| I->replaceAllUsesWith(UndefValue::get(I->getType())); | ||
| I = I->eraseFromParent(); | ||
|
|
||
| //* Remove args and their uses as well |
Useful extensible shortcuts to running tests.
Step 1 of optimizing atomic regions for (smaller) size.
robertzhidealx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the key changes:
autoand structured bindings (destructuring) where possible).benchmarks/ctests.