Node Attributes #141
Open
Node Attributes #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marthacryan
reviewed
Mar 2, 2023
Collaborator
marthacryan
left a comment
marthacryan
left a comment
There was a problem hiding this comment.
A few comments that are non-blocking on the code - still trying to test it out locally but the code LGTM
| const currentPath = `${tmpFolder}/${fileName}`; | ||
| const destinationPath = `${systemTdataFolder}/user-data-in/${fileName}`; | ||
| fs.rename(currentPath, destinationPath, function (err) { | ||
| fs.copyFile(currentPath, destinationPath, function (err) { |
Collaborator
There was a problem hiding this comment.
Why are you copying the file instead of renaming?
| editId, | ||
| } = this.state; | ||
| const { nodeId } = this.props; | ||
| console.log(nodeId); |
| this.onDeleteItems(props); | ||
| }} | ||
| renderIcon={Delete16} | ||
| iconDescription={'H'} |
Collaborator
There was a problem hiding this comment.
Should this be something more descriptive?
added 16 commits
March 9, 2023 16:52
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| annonNames.forEach((name) => { | ||
| const items = []; | ||
| const annotation = annotations[name]; | ||
| annotation.forEach((elem) => { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| annonNames.forEach((name) => { | ||
| const items = []; | ||
| const annotation = annotations[name]; | ||
| annotation.forEach((elem) => { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
added 8 commits
March 24, 2023 15:23
added 10 commits
March 28, 2023 15:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.