Open
Conversation
corrects biomass compartment values for Bily-Kriz since the raw data is given in t/ha but labeled as kg/ha
correct the conversion from gC m-2 to tC ha-1
correct flux unit conversion
This reverts commit 3854f3b.
corrects some minor issues that prevented compiling the database correctly
subsets Soro LAI measurement data to include only one measurement of LAI per year - two measurements are removed, one from August 2009 and one from August 2013
select new file with updated Soro tree data
include possibility of only showing DBH plot instead of DBH, height, DBH~height
read data on biomass compartments for Soro and include it in the STAND information
update tree data for Soro
included new authors and new DOI link of the updated Profound DB version
small typo corrections and DOI link changes produced with DB version 0.3
changed DOI link for new DB version 0.3
include new download link for DB version 0.3
include updates for the new DB version
Member
Author
|
Hi @matsmahnken , can you have a check about all the file changes (to the top right), and also check if this branch works with the new database. If so, I will merge this in master than then push the new version to CRAN |
Contributor
|
Yes, I'll do that. |
matsmahnken
requested changes
May 27, 2020
Contributor
matsmahnken
left a comment
matsmahnken
left a comment
There was a problem hiding this comment.
- another DOI link in the citation needs to be changed.
All other changes can be merged into master. DB version 0.3 works fine with package version 0.3.0. Did not find any problems when testing the main functions.
Also, when compiling the vignettes of the new DB version with the new package version a lot of the functionality is already used. Since everything worked fine without problems that is also a good way of ensuring that there are no problems.
ProfoundData/inst/CITATION
Outdated
| author = "Reyer, Christopher and Silveyra Gonzalez, Ramiro and Dolos, Klara and Hartig, Florian and Hauf, Ylva and Noack, Matthias and Lasch-Born, Petra and Rötzer, Thomas and Pretzsch, Hans and Meesenburg, Henning and Fleck, Stefan and Wagner, Markus and Bolte, Andreas and Sanders, Tanja and Kolari, Pasi and Mäkelä, Annikki and Vesala, Timo and Mammarella, Ivan and Pumpanen, Jukka and Matteucci, Giorgio and Collalti, Alessio and D’Andrea, Ettore and Foltýnová, Lenka and Krejza, Jan and Ibrom, Andreas and Pilegaard, Kim and Loustau, Denis and Bonnefond, Jean-Marc and Berbigier, Paul and Picart, Delphine and Lafont, Sébastien and Dietze, Michael and Cameron, David and Vieno, Massimo and Tian, Hanqin and Palacios, Alicia and Cicuendez, Victor and Recuero, Laura and Wieze, Klaus and Büchner, Matthias and Lange, Stefan and Volkholz, Jan and Kim, Hyungjun and Weedon, Graham and Sheffield, Justin and Vega del Valle, Iliusi and Suckow, Felicitas and Horemans, Joanna and Martel, Simon and Bohn, Friedrich and Steinkamp, Jörg and Chikalanov, Alexandre and Mahnken, Mats and Gutsch, Martin and Trotta, Carlo and Babst, Flurin and Frieler, Katja", | ||
| year = "2020", | ||
| doi = "10.5880/PIK.2020.006", | ||
| textVersion = "Reyer, C., Silveyra Gonzalez, R., Dolos, K., Hartig, F., Hauf, Y., Noack, M., … Frieler, K. (2019). The PROFOUND database for evaluating vegetation models and simulating climate impacts on forests [Data set]. https://doi.org/10.5880/pik.2019.008" |
Contributor
There was a problem hiding this comment.
doi link needs to be changed
update year and DOI link of DB citation
Contributor
|
from my side the pull request can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the database update