Rover 448 #13
Merged
Rover 448 #13
+157
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seems to work! - added ping library [https://www.npmjs.com/package/ping] to package,json - toast notifications to be done at a later date
- hosts are now solely taken from route.js
- basically merged the two versions together - removed a LOT of unnecessary padding and made graph shorter - should be able to see ~ 5 devices status w/ graph now - as always needs testing with rover before merging
ConnorNeed
approved these changes
Jan 15, 2026
Member
|
You are good to merge. Make sure to use "Squash and merge" option |
Member
|
Great work. |
Contributor
Author
|
Am I also good to delete this branch now, or should I keep it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added graph back + all suggestions, should be ready to go! (After more testing on the rover ofc.)