Skip to content

Remove rotate_from_matrix#1

Open
viljarjf wants to merge 1 commit intoCSSFrancis:use_phase_class2from
viljarjf:remove_rotate_from_matrix
Open

Remove rotate_from_matrix#1
viljarjf wants to merge 1 commit intoCSSFrancis:use_phase_class2from
viljarjf:remove_rotate_from_matrix

Conversation

@viljarjf
Copy link

@viljarjf viljarjf commented May 4, 2024

Description of the change

Removes ReciprocalLatticeVector.rotate_from_matrix, and "manually" rotate instead where it was used

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in credits in diffsims/release_info.py and
    in .zenodo.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant