Skip to content

refactor: permissions #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbriones1 wants to merge 17 commits into
base: main
Choose a base branch
from
Open

refactor: permissions #125

jbriones1 wants to merge 17 commits into from

Conversation

@jbriones1
Copy link
Contributor

@jbriones1 jbriones1 commented Dec 19, 2025

depends on #122
closes #124

  • Refactored permissions, they're now in src/utils/permissions.py
  • Created some Depends() functions to handle permissions on some endpoints
    • These will send back 401 or 403 depending on the check, so only use them if the endpoint requires a user and/or a certain permission level
  • Fixed up the Officers tests, the enabled ones should pass
  • Updated some Pydantic models
  • Updated some endpoints

@jbriones1
chore(pyproject): update install steps and change to using uv
c8ead80
@jbriones1
fix: python version pinned to 3.11
e6f1072
@jbriones1
chore(gitignore): update gitignore with uv items
0d4ce6c
@jbriones1
chore(pyright): update pyright config to use version 3.11
b7c305f
@jbriones1
chore(format): ignore alembic migrations
c94aa06
@jbriones1
chore(format): ran the formatter over the entire project
a721e4f
@jbriones1
fix(ci): fix script to not rely on requirements.txt
df0f490
@jbriones1
fix(ci): split test and dev dependencies again, update action script
01cb9f4
@jbriones1
fix(ci): removed requirements.txt requirement
8fe4e74
@jbriones1
fix(uv): update uv.lock to current state
5ab91f4
@jbriones1
refactor(permissions): rewrote permissions to integrate admin types
f571eb3
@jbriones1
fix: type errors in officers crud
74bc701
@jbriones1
refactor(permissions): restructured most endpoints to use Depends
4873317
@jbriones1
fix(tests): whole test suite can now be run
6c880e1
@jbriones1
fix: missing awaits on permission check calls
268fd97
@jbriones1
fix(officers): tests now all work
69469e1
@jbriones1
fix: move conftest.py to only work on integrations tests
6e39610
@jbriones1 jbriones1 mentioned this pull request Dec 21, 2025
Open
@jbriones1 jbriones1 marked this pull request as ready for review January 3, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use FastAPI Depends() to handle authentication on endpoints

2 participants

@jbriones1