[CBRD-26477] No copy operation during LOB data INSERT#6842
Draft
InChiJun wants to merge 160 commits intoCUBRID:developfrom
Draft
[CBRD-26477] No copy operation during LOB data INSERT#6842InChiJun wants to merge 160 commits intoCUBRID:developfrom
InChiJun wants to merge 160 commits intoCUBRID:developfrom
Conversation
http://jira.cubrid.org/browse/CBRD-23700 Because the review scope for CBRD-23700 is extensive, this PR merges the commits that have completed review into the feature branch ahead of the remaining work.
…in_truncate() func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-26477
Purpose
#6833 이후 서브 이슈로 진행되며, 설계 방향을 점검하기 위한 PR입니다.
LOB 데이터 INSERT 시 temp file을 copy하지 않고 move 하도록 합니다.
Implementation
before: heap_attrinfo_transform_variable_to_disk() -> db_elo_copy_with_prefix() -> elo_copy_with_prefix() -> es_copy_file_with_prefix() -> xes_posix_copy_file_with_prefix() -> copy file 수행
after: heap_attrinfo_transform_variable_to_disk() -> db_elo_move_with_prefix() -> elo_move_with_prefix() -> es_move_file_with_prefix() -> xes_posix_move_file_with_prefix() -> es_os_rename_file_abs() -> move file 수행
before -> after를 참고하시어 설계 방향 관점에서 리뷰해주시면 감사하겠습니다.
Remarks
-> 기존 lob 관련 로직에서는 move file 동작을 위한 코드가 없었기 때문에 새로운 로직을 추가해야 했습니다.
-> 다만 변경된 lob 구조에 맞게 file을 옮기려면 prefix라는 변수를 활용해야 합니다.
-> 기존 lob 로직과 설계에는 prefix라는 개념을 사용하지 않았기 때문에 prefix를 위한 함수를 새로 추가하는 것이 맞다 판단했습니다.
-> 이전 PR에서 commit 순서가 꼬여서 반영되지 않은 내용이 있습니다. 해당 내용을 포함하여 전체 코드 점검 후 리팩토링 코드도 추가하겠습니다.