Draft
Conversation
…n/sailbot into computer_vision
…n/sailros2 into computer_vision
Nikil-Shyamsunder
requested changes
Apr 19, 2025
setup/Dockerfile
Outdated
| ENTRYPOINT ["/home/ros2_user/setup_ros.sh"] | ||
| ############################################## | ||
| # Created from template ros2.dockerfile.jinja |
Member
There was a problem hiding this comment.
I think you changed the entire file from CRLF to LF or otherwise; this really confuses the diffs. change it back and just add your few line diff here.
| from sailboat_interface.msg import SailTail | ||
| from std_msgs.msg import Int32 | ||
|
|
||
| #import statement may or may not be necessary |
Member
There was a problem hiding this comment.
is it necessary or unnecessary? delete the comment and/or the import
teensy/src/constants.hpp
Outdated
| constexpr uint8_t RUDDER_MIN_ANGLE = 0; | ||
| constexpr uint8_t RUDDER_MAX_ANGLE = 90; | ||
|
|
||
| constexpr uint8_t TRACKER_PIN = 5; //TODO: change to correct pin number |
teensy/src/sfr.cpp
Outdated
| bool update_servos = false; | ||
|
|
||
| //int8_t buoy_displacement = 0; | ||
| int8_t servo_angle = 0; //what should the default value be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still to do: