Conversation
Author: Caldis <532607446@qq.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds new highlight.js CSS theme files, font configuration, and updates to core TypeScript files. The changes primarily introduce visual styling assets and make minor formatting improvements to existing code.
Key Changes:
- Added 100+ highlight.js CSS theme files for syntax highlighting
- Added Ubuntu font configuration and highlight.js library files
- Updated TypeScript formatting in
anim.tsandanim.lessfor consistency
Reviewed Changes
Copilot reviewed 223 out of 378 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/home/public/highlight/styles/*.css |
Added 100+ syntax highlighting theme stylesheets |
packages/home/public/highlight/highlight.pack.js |
Added minified highlight.js library (v10.7.2) |
packages/home/public/highlight/README.md |
Added highlight.js documentation |
packages/home/public/highlight/LICENSE |
Added BSD 3-Clause license for highlight.js |
packages/home/public/fonts/ubuntu/font.css |
Added Ubuntu font face definitions |
packages/home/public/CNAME |
Added custom domain configuration |
packages/home/package.json |
Added home package configuration |
packages/home/index.html |
Added HTML entry point with highlight.js integration |
packages/core/vitest.config.ts |
Added Vitest test configuration |
packages/core/tsup.config.ts |
Added build configuration with LESS processing |
packages/core/tsconfig.json |
Added TypeScript compiler configuration |
packages/core/src/config/anim.ts |
Fixed spacing in animation function and added missing semicolon |
packages/core/src/config/anim.less |
Updated LESS animation values for consistency |
packages/core/src/**/*.{ts,tsx,less} |
Added core React component files and utilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| .hljs-selector-id, | ||
| .hljs-selector-class { | ||
| color: #9B703F |
There was a problem hiding this comment.
Missing semicolon at end of CSS property declaration. Add semicolon after #9B703F for consistency with CSS best practices.
| color: #9B703F | |
| color: #9B703F; |
| .hljs-literal, | ||
| .hljs-deletion, | ||
| .hljs-link { | ||
| color: #cc6666 |
There was a problem hiding this comment.
Missing semicolon at end of CSS property declaration. Add semicolon after #cc6666.
| color: #cc6666 | |
| color: #cc6666; |
| .hljs-attribute, | ||
| .hljs-code, | ||
| .hljs-selector-id { | ||
| color: #b294bb; |
There was a problem hiding this comment.
Missing semicolon at end of CSS property declaration on line 67. The property color: #b294bb; on line 64 has a semicolon, but line 67 is missing one.
| .hljs-selector-tag, | ||
| .hljs-bullet, | ||
| .hljs-tag { | ||
| color: #81a2be; |
There was a problem hiding this comment.
Missing semicolon at end of CSS property declaration on line 75. Add semicolon after #81a2be.
|
|
||
| .hljs-number, | ||
| .hljs-deletion { | ||
| color:#ff73fd; |
There was a problem hiding this comment.
Missing space after colon in CSS property. Should be color: #ff73fd; for consistency with the rest of the file.
| color:#ff73fd; | |
| color: #ff73fd; |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| window.addEventListener('test', null, Object.defineProperty({}, 'passive', { | ||
| get: function () { | ||
| supportsPassive = true | ||
| } |
There was a problem hiding this comment.
The new SSR/RSC guidance advertises react-zmage/ssr, but utils/index.ts still executes window.addEventListener (and later document.createElement) as soon as the module is imported. In a server or edge runtime (e.g., Next.js App Router server components) window/document are undefined, so simply importing the SSR entry will throw before React can render. The DOM access needs to be guarded or deferred to browser-only lifecycle hooks for the SSR build to work.
Useful? React with 👍 / 👎.
1 participant
No description provided.