This repository was archived by the owner on Mar 19, 2018. It is now read-only.
Open
Conversation
Member
|
Thanks for fixing this. So do you suggest creating a ticket that overhauls buffer checking in general? To be honest, I didn't check whether it's working or not for a long time. Edit: Will merge in the evening to update versions, build, etc. |
|
Even I am facing same issues |
Member
|
Have been in NY the last week, looking over it tomorrow or the day after. |
|
Is this still a problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general buffer checking does not work at all (tested with the latest versions of Chrome, Safari and Firefox and videos > 1h).
But turning off buffer checking permanently does not work currently too, as checkBuffer = false has been removed from sjs:stopBufferChecker. Without setting this, buffer checking will be enabled again as soon as someone presses play.