This repository was archived by the owner on Mar 19, 2018. It is now read-only.
Fix for setBufferChecker, which keeps video in pause state. Checking…#14
Open
damoeb wants to merge 1 commit intoCallToPowerLegacy:masterfrom
damoeb:t/buffer-status-check-is-invalid
Open
Fix for setBufferChecker, which keeps video in pause state. Checking…#14damoeb wants to merge 1 commit intoCallToPowerLegacy:masterfrom damoeb:t/buffer-status-check-is-invalid
damoeb wants to merge 1 commit intoCallToPowerLegacy:masterfrom
damoeb:t/buffer-status-check-is-invalid
Conversation
… for currentTime + bufferInterval may fail in some browsers, cause bufferInterval is an implementation details of a browser and hence not required for the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for currentTime + bufferInterval may fail in some browsers, cause bufferInterval conflicts with implementation details of browsers and hence not required for the check. You cannot control how much a browser will buffer. Chrome Version 51.0.2704.103 (64-bit) never reached the threshold bufferInterval after moving to an uncached part of the video.
Reproduce: Move currentTime to an part of the video that is not yet buffered and the player will stall in pause mode.