Skip to content
This repository was archived by the owner on Dec 15, 2025. It is now read-only.

Subset cambio-ai.com#82

Merged
boqiny merged 1 commit intomainfrom
20250416
Apr 16, 2025
Merged

Subset cambio-ai.com#82
boqiny merged 1 commit intomainfrom
20250416

Conversation

@goldmermaid
Copy link
Member

@goldmermaid goldmermaid commented Apr 16, 2025

User description

Subset cambio-ai.com

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement

How Has This Been Tested?

Screenshots (if applicable)

AnyParser public API issues.
image

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes


PR Type

  • Bug fix

Description

  • Updated API URLs to new domain

  • Replaced cambio-ai.com with cambioml.com


Changes walkthrough 📝

Relevant files
Bug fix
any_parser.py
Update API base URLs to new domain                                             

any_parser/any_parser.py

  • Changed PUBLIC_SHARED_BASE_URL to cambioml.com
  • Changed PUBLIC_BATCH_BASE_URL to cambioml.com
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    API URL Update

    Ensure that the updated API URLs are correct and intended. Verify if the use of HTTP for the batch URL is deliberate and consistent with the security model.

    PUBLIC_SHARED_BASE_URL = "https://public-api.cambioml.com"
    PUBLIC_BATCH_BASE_URL = "http://batch-api.cambioml.com"

    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Security
    Use HTTPS for security

    Consider updating the batch API base URL to use HTTPS for secure communication if
    possible.

    any_parser/any_parser.py [26]

    -PUBLIC_BATCH_BASE_URL = "http://batch-api.cambioml.com"
    +PUBLIC_BATCH_BASE_URL = "https://batch-api.cambioml.com"
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies a potential security improvement by updating the batch API URL to HTTPS, and it is accurately applied to the added line in the PR.

    Medium

    @boqiny boqiny merged commit 11f2069 into main Apr 16, 2025
    1 of 2 checks passed
    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants