[Feature](mluOpLogcumsumexp):add new op#1027
Open
shouhoo wants to merge 84 commits intoCambricon:masterfrom
Open
[Feature](mluOpLogcumsumexp):add new op#1027shouhoo wants to merge 84 commits intoCambricon:masterfrom
shouhoo wants to merge 84 commits intoCambricon:masterfrom
Conversation
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
|
|
||
| 及格： 算子 hw time 是竞品 v100 的 15 倍 | ||
|
|
||
| - （此标准用于竞品实现是单算子实现， 若竞品使用算子拼接的方式实现， 需单独说明） |
Collaborator
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
建议修改为上述贴的链接中的表格形式，表格后文字补充370S4 在上述规模下时间开销需保持在 *** 几倍范围内
而不是
“良好： 算子 hw time 是竞品 v100 的 8 倍 ”， 什么是V100 8倍， 是超过还是低于？
Collaborator
Author
There was a problem hiding this comment.
该算子的典型规模有10个，两种数据类型一共有20行。这个表格放在测试报告里是否会更好？
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
PetrelYy
reviewed
May 22, 2024
test/mlu_op_gtest/pb_gtest/src/zoo/logcumsumexp/test_case/case0.prototxt
Show resolved
Hide resolved
PetrelYy
reviewed
May 22, 2024
test/mlu_op_gtest/pb_gtest/src/zoo/logcumsumexp/logcumsumexp.cpp
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
May 22, 2024
| error_func: DIFF1 | ||
| error_func: DIFF2 | ||
| error_threshold: 0.003 | ||
| error_threshold: 0.003 |
Collaborator
There was a problem hiding this comment.
补充
- proto
- mlu_op.h
- docs/bangc-docs/user_guide/9_operators/index.rst 算子说明
- 完善测试报告 1. cpu case pass + generator 生成网络规模 + 其他随机规模的功能测试
- 完善测试报告 2. 性能测试结果
Collaborator
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
还缺少
- op.h 接口注释
- docs/bangc-docs/user_guide/9_operators/index.rst 算子说明
- 测试报告
chen4231
reviewed
Aug 21, 2024
Collaborator
|
除了任务书的规模，有没有自己另外加一些规模生成GPU测例测试？ 把运行成功的log也贴一下吧 |
chen4231
reviewed
Sep 2, 2024
mlu_op.h
Outdated
| * @par Data Layout | ||
| * - ::MLUOP_LAYOUT_ARRAY | ||
| * | ||
| * @par Scale Limitation |
Collaborator
There was a problem hiding this comment.
是算子自身的限制， dim要在[ -input->dims, input->dims -1 ]范围内
Collaborator
There was a problem hiding this comment.
The parameter "dim" -> The value of \p dim
chen4231
previously approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
代码已完成，要求测例的自测均通过，等待评审