Makes make_ace_lib more flexible#188
Merged
ChasingNeutrons merged 13 commits intoCambridgeNuclear:mainfrom Feb 18, 2026
Merged
Conversation
valeriaRaffuzzi
commented
Jan 14, 2026
docs/Installation.rst
Outdated
| To get extra help run the script without any arguments. In the line above, <output> is the file that | ||
| will be created; <MODE> can be either ``CE`` for continuous energy neutron data cards and ``SAB`` for | ||
| thermal scattering S(α,β) cards; <extension_suffix> is the final part of the extension that is common to | ||
| all the ace files of interest; <path_to_base_folder> is the path to the folder than contains the ace |
Collaborator
There was a problem hiding this comment.
Here I would add the two common examples for ease of use (i.e., "often this is 'ace' or, for some newer evaluations, 'nc' "). I guess there's also a question of what if the file doesn't have that suffix? For example, we used to be able to process the sssth1 file for S(a,b) provided with Serpent. Would that still work now?
Member
Author
There was a problem hiding this comment.
Good points! I made it a bit more general and now the search keyword doesn't have to be in the extension at all (I don't know why I was limiting that before!). Now it should be more flexible and all this should be addressed - I tested on several combinations including the Serpent sssth1 file.
ChasingNeutrons
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #178 : modifies the script make_ace_lib to be recursive. It now requires a suffix to look for files and a base folder.